Skip to content

Vec, String: add some missing const-hack comments #137328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Vec, String: add some missing const-hack comments #137328

wants to merge 1 commit into from

Conversation

RalfJung
Copy link
Member

#128399 added these unsafe blocks and as far as I can tell that's entirely due to const-eval limitations.

r? @tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 20, 2025
@tgross35
Copy link
Contributor

That PR actually moved the implementations - it used to be that as_str and friends would call deref, which had the unsafe implementation. But #128399 flipped them so as_str has the implementation and deref calls that, the unsafe block isn't repeated. Is there a reason to flip them back when possible?

@RalfJung
Copy link
Member Author

You're right, I missed that this is just moved code, not new code.

@RalfJung RalfJung closed this Feb 21, 2025
@RalfJung RalfJung deleted the string-vec-const-hack branch February 21, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgross35 tgross35

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RalfJung @tgross35 @rustbot